SK-2482: add linter to python sdk v2 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR integrates the Ruff linter into the Python SDK v2 to enforce PEP 8 naming conventions and improve code quality. The linter is configured to focus specifically on naming consistency checks.
Changes:
- Added Ruff as a development dependency
- Configured Ruff with PEP 8 naming rules and appropriate exclusions
- Integrated Ruff into the CI workflow for automated checks
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Added 'ruff' to dev dependencies |
| ruff.toml | Created configuration file with naming rules and exclusions |
| .github/workflows/shared-tests.yml | Added Ruff linter step to CI pipeline |
| skyflow/utils/validations/_validations.py | Removed trailing blank line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
saileshwar-skyflow
approved these changes
Jan 20, 2026
skyflow-bharti
approved these changes
Jan 20, 2026
Devesh-Skyflow
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Integrate ruff linter to python SDK v2 to identify naming inconsistencies in interfaces
Goal:
Integrate ruff linter to identify naming inconsistencies with a focused rule set